Skip to content

chore(deps): update dependency @sap/cds-compiler to v6.8.0#380

Open
renovate[bot] wants to merge 2 commits intomainfrom
renovate/sap-cds-compiler-6.x
Open

chore(deps): update dependency @sap/cds-compiler to v6.8.0#380
renovate[bot] wants to merge 2 commits intomainfrom
renovate/sap-cds-compiler-6.x

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Mar 9, 2026

This PR contains the following updates:

Package Change Age Confidence
@sap/cds-compiler 6.7.36.8.0 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
Copy link
Contributor Author

renovate bot commented Mar 9, 2026

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@zongqichen
Copy link
Contributor

Hi @stewsk, we found that there is new content in csn introduced in new version:

FAIL __tests__/unit/ord.e2e.test.js
  ● Tests for Data Product definition › Check interop CSN content

    expect(received).toMatchSnapshot()

    Snapshot name: `Tests for Data Product definition Check interop CSN content 1`

    - Snapshot  - 0
    + Received  + 1

    @@ -1102,10 +1102,11 @@
          },
        },
        "meta": {
          "__name": "DPBooks",
          "__namespace": "sap.capdpprod",
    +     "compilerCsnFlavor": "inferred",
          "document": {
            "version": "1.0.0",
          },
          "flavor": "effective",
        },

      295 |         expect(interopCsn.i18n.de.Stock).toBe("Bestand");
      296 |
    > 297 |         expect(interopCsn).toMatchSnapshot();
          |                            ^
      298 |     });
      299 |
      300 |     it("Check interop CSN annotation mapping through ORD", async () => {

      at Object.toMatchSnapshot (__tests__/unit/ord.e2e.test.js:297:28)

Should we update our snapshot? Or it is something not on purpose?

Best,
Zongqi

@stewsk
Copy link
Contributor

stewsk commented Mar 10, 2026

Hi @zongqichen , the change is on purpose, so yes, please update the snapshot.
Alternatively you could ignore all the properties inside the meta section that you are not interested in.

@stewsk
Copy link
Contributor

stewsk commented Mar 11, 2026

Hi @zongqichen , as discussed in the meeting with GreenLedger, I'm going to remove the `compilerCsnFlavor" from the meta. Is it ok if I do it in this PR?

@zongqichen
Copy link
Contributor

Hi @zongqichen , as discussed in the meeting with GreenLedger, I'm going to remove the `compilerCsnFlavor" from the meta. Is it ok if I do it in this PR?

Hi @stewsk, I would suggest create a new pr for better tracking. You can link this error in the new one

@stewsk
Copy link
Contributor

stewsk commented Mar 11, 2026

ok. With this other change (-> #387) it is then of course no longer necessary to adapt the snapshot

@stewsk
Copy link
Contributor

stewsk commented Mar 11, 2026

failing test is addressed in #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants