chore: Refactor 'metaData.js'

[mlakov]

♻️ Refactor metaData.js with Frozen Compiler Map and Modernized Tests

Refactor

Replaced the large switch statement in metaData.js with a frozen compilers map for cleaner, more maintainable metadata compilation logic. Also modernized test assertions to use idiomatic async Jest patterns throughout the test suite.

Changes

• lib/metaData.js:

  • Added path module import and reordered assert/cdsc declarations for better organization.
  • Extracted extractServiceName(url) and extractCompilerType(url) as standalone helper functions, replacing inline URL parsing logic.
  • Removed the _getServersFromAnnotation helper and the switch-based compiler dispatch; replaced with a frozen compilers object (Object.freeze) mapping each COMPILER_TYPES key to its own async handler.
  • Each compiler entry now directly declares its own contentType, eliminating the manual content type derivation logic previously inferred from the compiler name.
  • Consolidated error handling into a single .catch() with a unified log message: Compilation failed for service ${serviceName} (compiler: ${compilerType}) - ${error.message}.

• __tests__/unit/metaData.test.js:

  • Replaced all try/catch assertion patterns with await expect(...).rejects.toThrow(...) for idiomatic async Jest error testing.
  • Replaced const result = await ...; expect(result)... patterns with await expect(...).resolves.toEqual(...) for cleaner async success assertions.
  • Removed the "getMetadata should handle invalid URL format" test case (the explicit "Invalid URL format" error no longer exists).
  • Renamed "getMetadata should raise error when get edmx failed" to "getMetadata should raise error when get OpenAPI failed" to align with the updated test URL and error.

• 🔄 Regenerate and Update Summary

---

📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

PR Bot Information

Version: 1.18.5 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• Event Trigger: pull_request.edited
• LLM: anthropic--claude-4.6-sonnet
• Output Template: Default Template
• Summary Prompt: Default Prompt
• Correlation ID: 26e52080-1e60-11f1-9318-c014ee0ee278

[hyperspace-insights]

The refactor is generally clean and well-structured. Two issues were raised: (1) the assert for unsupported format types fires synchronously before the .catch() error-logging handler, causing unsupported-format errors to be silently swallowed without logging; and (2) extractServiceName and extractCompilerType redundantly parse the same URL twice, which is also fragile for non-.json extensions — these should share a single parse.

PR Bot Information

Version: 1.17.99 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• Correlation ID: 1a62a280-1c4c-11f1-9007-7e27141b47b4
• Event Trigger: pull_request.opened
• Agent Instructions:
  • .github/copilot-instructions.md
• LLM: anthropic--claude-4.6-sonnet

[zongqichen]

Solid refactor and clean some legacy bugs or codes, appreciate it. Some comments we can discuss.

[zongqichen]

LGTM