Skip to content

fix: e.stack?.split() #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjvans merged 3 commits into from
Dec 10, 2025
Merged

fix: e.stack?.split() #404

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fbfed2
fix: `e.stack?.split()`
sjvans Dec 9, 2025
390ffe2
Merge branch 'main' into stack
sjvans Dec 10, 2025
597ef2b
Merge branch 'main' into stack
sjvans Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/logging/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ module.exports = resource => {
attributes['exception.stacktrace'] = e.stack
attributes['exception.type'] = e.name
// remove stack from message, if present
log.msg = log.msg.replace(e.stack, e.stack.split('\n')[0])
// NOTE: an error should always have a stack, but there was an issue report where it somehow was undefined
log.msg = log.msg.replace(e.stack, e.stack?.split('\n')[0])
}
for (const field of custom_fields) if (field in log) attributes[field] = log[field]
logger.emit({
Expand Down