Skip to content

fix: closing animation on iOS to be similar to modal closing animation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulienLecoq wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: closing animation on iOS to be similar to modal closing animation #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c77e339
fix: closing animation on iOS to be similar to modal closing animation
JulienLecoq Mar 11, 2025
739a146
Merge branch 'main' into fix/ios-closing-animation
JulienLecoq May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/Plugin/Extensions/UIViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ extension UIViewController {
let transition = CATransition()
transition.duration = 0.5
transition.timingFunction = CAMediaTimingFunction(name: CAMediaTimingFunctionName.easeInEaseOut)
transition.type = CATransitionType.push
transition.type = CATransitionType.reveal
if swipeDirection == "up" {
transition.subtype = CATransitionSubtype.fromTop
} else if swipeDirection == "down" {
Expand Down
2 changes: 1 addition & 1 deletion ios/Plugin/OnePhoto/OneImageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ class OneImageViewController: UIViewController, UIScrollViewDelegate {
NotificationCenter.default.post(name: .photoviewerExit,
object: nil,
userInfo: vId)
self.dismissWithTransition(swipeDirection: "no")
self.dismissWithTransition(swipeDirection: "down")
// self.dismiss(animated: true, completion: nil)
}

Expand Down
2 changes: 1 addition & 1 deletion ios/Plugin/PhotoSlider/SliderViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ class SliderViewController: UIViewController {
object: nil,
userInfo: vId)
}
self.dismissWithTransition(swipeDirection: "no")
self.dismissWithTransition(swipeDirection: "down")
}

// MARK: - shareButtonTapped
Expand Down