[deps] upgrade libphonenumber to 9.0.22#312
Merged
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/build.gradle`:
- Line 127: The project just upgraded the libphonenumber dependency
(implementation 'com.googlecode.libphonenumber:libphonenumber:9.0.22') which
requires a Java 8+ baseline and preserved metadata/resources for runtime; update
the Java target compatibility settings (set
sourceCompatibility/targetCompatibility or compileOptions to
JavaVersion.VERSION_1_8 or higher in your Gradle config) and add the R8/ProGuard
keep rules to your proguard-rules.pro (preserve
assets/com/google/i18n/phonenumbers/** and keep classes/members/attributes for
com.google.i18n.phonenumbers.** and parameter names) so metadata and public APIs
aren’t stripped; if you use an Android-repackaged fork (e.g.,
io.michaelrocks:libphonenumber-android) adapt the package paths accordingly and
run phone parsing/formatting tests before release.
Contributor
🤖 Pull request artifacts
|
90d3b93 to
a53b530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.