Merged
Conversation
Contributor
|
@BraunMatthias Could you give a review? |
agoerler
approved these changes
May 21, 2025
Contributor
agoerler
left a comment
agoerler
left a comment
There was a problem hiding this comment.
LGTM, although we could also mention SDM: https://github.com/cap-java/sdm
|
|
||
|
|
||
| The Attachments plugin provides out-of-the-box handling of attachments stored in, for example, AWS S/3 through [SAP BTP's Object Store service](https://discovery-center.cloud.sap/serviceCatalog/object-store). To use it, simply add a composition of the predefined aspect `Attachments` like so: | ||
| The Attachments plugin provides out-of-the-box support for attachment handling. On Node.js, attachments are stored on AWS S/3 through [SAP BTP's Object Store service](https://discovery-center.cloud.sap/serviceCatalog/object-store), whereas Java stores attachments on the SAP HANA database. To use it, simply add a composition of the predefined aspect `Attachments` like so: |
Contributor
There was a problem hiding this comment.
I think we might also mention that in CAP Java also SDM can be used to store attachements: https://github.com/cap-java/sdm
Contributor
Author
There was a problem hiding this comment.
SDM is a seperate section right under Attachments on the plugin page, as for node those are two seperate plugins
renejeglinsky
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two plugins for node and java have some major differences.
In node the Object Store is used, while java stores attachments on HANA db.
This has knock-on effects on topics like mtx, encryption etc.