Skip to content

Returning media data in actions and functions#1939

Merged
renejeglinsky merged 3 commits intomainfrom
returning-media-data-in-actions
Sep 2, 2025
Merged

Returning media data in actions and functions#1939
renejeglinsky merged 3 commits intomainfrom
returning-media-data-in-actions

Conversation

@davidhunglam
Copy link
Contributor

Added subsection about returning media data streams in custom actions and functions.

Added subsection about returning media data streams in custom actions and functions.
@davidhunglam davidhunglam requested a review from rjayasinghe June 27, 2025 10:11
@renejeglinsky renejeglinsky requested review from stewsk and removed request for mofterdinger and rjayasinghe August 22, 2025 09:27
@stewsk
Copy link
Contributor

stewsk commented Aug 25, 2025

Hi @davidhunglam ,
is this relevant for all kinds of services or is it specific for OData?
If OData specific, this section should better be placed in https://pages.github.tools.sap/cap/docs/advanced/odata.

@davidhunglam
Copy link
Contributor Author

Hi @davidhunglam , is this relevant for all kinds of services or is it specific for OData? If OData specific, this section should better be placed in https://pages.github.tools.sap/cap/docs/advanced/odata.

Okay thanks, I'll move it.

@davidhunglam
Copy link
Contributor Author

davidhunglam commented Aug 25, 2025

@stewsk: on second thought, in my opinion, annotating operation returns with @Core.MediaType is not really adapter specific. It's just that there's currently an implementation only for OData services, but in theory this could be supported also for HCQL, etc.

Do you still think it should be moved?

@stewsk
Copy link
Contributor

stewsk commented Aug 25, 2025

Hi @davidhunglam , if you think this is not only relevant for OData but in general, then that's ok.

@renejeglinsky
Copy link
Contributor

Is this shown in a sample?

@davidhunglam
Copy link
Contributor Author

Is this shown in a sample?

No, not yet.

@renejeglinsky renejeglinsky requested a review from smahati as a code owner August 26, 2025 11:15
@renejeglinsky renejeglinsky merged commit f560ea0 into main Sep 2, 2025
7 checks passed
@renejeglinsky renejeglinsky deleted the returning-media-data-in-actions branch September 2, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants