Skip to content

Conversation

@danjoa
Copy link
Member

@danjoa danjoa commented Aug 2, 2025

@swaldmann During my consolidation activities, I wondered whether that would work and be reasonable?

@danjoa danjoa requested a review from swaldmann August 2, 2025 06:55
@swaldmann
Copy link
Contributor

It's possible for event-mesh.json and xs-security.json, as I did in 29fd6b5.

<cwd>/mta.yaml however is a hardcoded path in the mbt tool 😐. If we move it to .deploy we have to

  1. run mbt build from .deploy and not from root (not what people are used to)
  2. adapt some paths in the mta.yaml to point to ../ (making it less portable as a sample w/ old folder structure)

We could also think about generating the mta using cds add mta – that's currently not possible to implement in our microservices scenario as the mta.yaml itself is the single-source-of-truth for which submodules to include:

samples/mta.yaml

Lines 12 to 15 in 6022d7f

- npx cds build shared-db --for hana --production
- npx cds build orders --for nodejs --production --ws-pack
- npx cds build reviews --for nodejs --production
- npx cds build bookstore --for nodejs --production --ws-pack

If enough information is provided in either in the outer package.json, e.g.

"requires": {
  "reviews": "./reviews",
  "orders": "./orders",
  "bookstore": "./bookstore",
  "shared-db": "./shared-db",
}

or (similar to cds-plugin technique) some config in the submodules we'd have enough information to derive the mta.yaml.

@danjoa
Copy link
Member Author

danjoa commented Aug 8, 2025

Thanks Steffen! I would be absolutely fine with 29fd6b5, leaving mta.yaml top-level (... for the time being ;)

@swaldmann swaldmann marked this pull request as ready for review August 12, 2025 11:43
@swaldmann swaldmann merged commit 5291205 into main Aug 12, 2025
3 checks passed
@swaldmann swaldmann deleted the out-of-sight branch August 12, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants