-
Notifications
You must be signed in to change notification settings - Fork 602
Update appwrite one-click to v17 #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Just a couple of questions to make sure things are not accidentally removed.
This is perhaps the most complex app that we have on the official repo at this point. Almost 1300 lines of yaml... impressive!
environment: | ||
_APP_INFLUXDB_HOST: srv-captain--$$cap_appname-influxdb | ||
_APP_INFLUXDB_PORT: $$cap_APP_INFLUXDB_PORT | ||
MYSQL_ROOT_PASSWORD: $$cap_APP_DB_ROOT_PASS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the MariaDB prefixes changed to MySQL? Official docs seem to suggest MYSQL_ROOT_PASSWORD
etc are valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InfluxDB was removed in appwrite 1.7 official docker compose file, I dont completely understand what is was converted into, but it seems that they wrote their own internal tools to replace it and telegraf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MYSQL_ROOT_PASSWORD is for MariaDB and is mapping to the environment variable from appwrite APP_DB_ROOT_PASS. Currently appwrite only supports MariaDB and in their official self-hosted docker_compose file it uses MYSQL_ROOT_PASSWORD for it.
volumes: | ||
- $$cap_appname-influxdb:/var/lib/influxdb | ||
|
||
$$cap_appname-telegraf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is telegraf no longer needed? Same with Influxdb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telegraf was removed in appwrite 1.7 official docker compose file, I dont completely understand what is was converted into, but it seems that they wrote their own internal tools to replace it and influxDB.
I updated the appwrite.yml file for my own use-case and it works perfect. Thought maybe the community would like it