Fix LoongArch ld/st instructions register info #2701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested changes
May 16, 2025
jiegec
added a commit
to jiegec/capstone
that referenced
this pull request
May 16, 2025
Access type validation is added to tests/details/loongarch.yaml to strengthen the new tests introduced in pull request capstone-engine#2701.
Rot127
approved these changes
May 16, 2025
Member
|
@jiegec Can you plz solve the conflict in yaml so I can merge? thx:) |
According to capstone-engine#2700, the register info of LoongArch ld/st instructions is wrong. A fix for the issue is proposed for llvm-capstone at capstone-engine/llvm-capstone#79. This commit integrates the fix and regenerates the tables via `ASUpdater -a LoongArch -w -s IncGen`. The case change in LoongArchGenCSOpGroup.inc is also handled. Fixes: capstone-engine#2700
Collaborator
Author
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
According to #2700, the register info of LoongArch ld/st instructions is wrong. A fix for the issue is proposed for llvm-capstone at capstone-engine/llvm-capstone#79. This commit integrates the fix and regenerates the tables via
ASUpdater -a LoongArch -w -s IncGen. The case change in LoongArchGenCSOpGroup.inc is also handled.Test plan
Tested via
./build/suite/cstest/cstest tests/details/loongarch.yamlClosing issues
Fixes: #2700