Make assertion hit warnings optional in release builds. #2729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
force-pushed
the
optional-assert-warn
branch
from
6f7845f to
6e91bba
Compare
jiegec
reviewed
Jun 15, 2025
jiegec
reviewed
Jun 15, 2025
github-actions
bot
added
LLVM-generated-files
Github-files
wargio
approved these changes
Jun 15, 2025
jiegec
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Makes the error message printing in case of an assert hit optional.
Companion PR to fix the build: capstone-engine/llvm-capstone#82
Test plan
Added release and release with warnings builds to the CI.
Closing issues
...