Update read/written registers for x86 enter/leave instructions - #2788
Merged
Conversation
Rot127
approved these changes
Sep 22, 2025
|
|
||
| case X86_INS_ENTER: | ||
| case X86_INS_LEAVE: | ||
| switch (h->mode) { |
Collaborator
There was a problem hiding this comment.
The registers for CS_MODE_32 are alright and need no change?
Contributor
Author
There was a problem hiding this comment.
The entry in the mapping file uses the 32-bit registers by default. I added tests for that case, just to make sure.
Collaborator
|
Please rebase |
hainest
force-pushed
the
thaines/x86_enter_leave
branch
from
October 1, 2025 19:44
f34c62c to
f589611
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
The
spandbpregisters are now converted to the correct 16- and 64-bit versions.Test plan
Tests are included.