Fix assertions if CAPSTONE_ASSERTION_WARNINGS=1. - #2792
Merged
Conversation
github-actions
Bot
added
CS-core-files
Rot127
marked this pull request as draft
September 30, 2025 11:03
Rot127
force-pushed
the
assert
branch
17 times, most recently
from
September 30, 2025 16:06
b247ccc to
ac78ba4
Compare
Collaborator
Author
|
@hgarrereyn If you find time I would grateful if you could check the macro changes as well. |
Rot127
marked this pull request as ready for review
September 30, 2025 16:45
jiegec
reviewed
Oct 1, 2025
It changes now to the following behavior: - Debug && !defined(CAPSTONE_ASSERTION_WARNINGS) - `assert(expr)` code is included, warning is not printed if hit. - Debug && defined(CAPSTONE_ASSERTION_WARNINGS) - `assert(expr)` code is included, warning is printed if hit. - Release && !defined(CAPSTONE_ASSERTION_WARNINGS) - `assert(expr)` code is not included, warning is not printed if hit. - Release && defined(CAPSTONE_ASSERTION_WARNINGS) - `assert(expr)` code is not included, warning is printed if hit. This also fixes the inconsistent (buggy) behavior from before. The variants of CS_ASSERT_RET(_VAL) did not return if the assertions were disabled (release build). So the semantics were different.
Collaborator
Author
|
@jiegec Can you check a second time when you find time? |
kabeor
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
It changes now to the following behavior:
CAPSTONE_ASSERTION_WARNINGSprint_warning() ; assertassertprint_warning(){}This also fixes the inconsistent (buggy) behavior from before.
The variants of CS_ASSERT_RET(_VAL) did not return if
the assertions were disabled (release build).
So the semantics were different.
Test plan
Added and old ones adjusted.
Closing issues
closes #2791