Skip to content

Fix 32bit build - #2796

Merged
Rot127 merged 16 commits into
capstone-engine:nextfrom
Rot127:32bit
Feb 15, 2026
Merged

Fix 32bit build#2796
Rot127 merged 16 commits into
capstone-engine:nextfrom
Rot127:32bit

Conversation

@Rot127

@Rot127 Rot127 commented Oct 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Fixes the 32bit build and enables the tests for it.

  • Remove all usage of va_args and updates Mips, LoongArch, ARM, and PPC to use the ARCH_add_cs_detail_X() functions instead of the generic add_cs_detail().
  • Fixes several bugs related to unspecified type widths and not portable formatting.
  • Adds several cross builds for testing.

Test plan

All Python 32bit builds and tests must be green.

Closing issues

closes #2458
addresses #2416 for v6.

@github-actions github-actions Bot added Documentation Github-files Github related files labels Oct 12, 2025
@Rot127 Rot127 mentioned this pull request Oct 17, 2025
Closed
2 tasks
@Rot127
Rot127 marked this pull request as ready for review October 20, 2025 12:34
@Rot127

Rot127 commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator Author

@Antelox Please review as well.

I can't download the test logs (some Github bug as it looks like) to confirm everything went through without bugs.
So mark it as draft until I could.

@Rot127
Rot127 marked this pull request as draft October 20, 2025 12:55
@github-actions github-actions Bot added the Python Bindings label Oct 20, 2025
@Rot127 Rot127 mentioned this pull request Oct 21, 2025
Open
@Rot127
Rot127 force-pushed the 32bit branch 2 times, most recently from 2fef2d2 to beb4889 Compare October 29, 2025 18:31
@Rot127
Rot127 force-pushed the 32bit branch 2 times, most recently from d6c57a8 to 6c50d48 Compare February 10, 2026 00:21
@github-actions github-actions Bot added the M68K Arch label Feb 10, 2026
@Rot127 Rot127 changed the title 32bit build Fix 32bit build Feb 13, 2026
@Rot127 Rot127 mentioned this pull request Feb 13, 2026
Draft
6 tasks
@Rot127
Rot127 marked this pull request as ready for review February 13, 2026 17:12
@Rot127
Rot127 merged commit 3533a9c into capstone-engine:next Feb 15, 2026
35 checks passed
@Rot127
Rot127 deleted the 32bit branch February 15, 2026 16:14
@Rot127 Rot127 mentioned this pull request May 29, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiegec jiegec Awaiting requested review from jiegec
@wtdcode wtdcode Awaiting requested review from wtdcode
@kabeor kabeor Awaiting requested review from kabeor
2 more reviewers
@wargio wargio wargio approved these changes
@notxvilka notxvilka notxvilka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AArch64 Arch ARC ARM Arch Auto-Sync-files Auto-Sync Documentation Github-files Github related files LoongArch Arch M68K Arch Mips Arch MOS65XX Arch Python Bindings SystemZ Arch X86 Arch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UB on PPC because vargs are not casted.

3 participants

@Rot127 @wargio @notxvilka