Fix position of comments to not break const_generator.py - #2906
Merged
Conversation
github-actions
Bot
added
ARM
historicattle
changed the title
historicattle
force-pushed
the
const
branch
2 times, most recently
from
April 27, 2026 10:44
7af2eb3 to
a6101ec
Compare
Signed-off-by: Naren Sirigere <sirigere.naren@gmail.com>
historicattle
changed the title
Contributor
Author
|
The changes needed to be done to the generator for riscv is best to be done in a separate PR |
historicattle
marked this pull request as ready for review
April 27, 2026 13:03
Rot127
approved these changes
Apr 28, 2026
Rot127
left a comment
Rot127
left a comment
Collaborator
There was a problem hiding this comment.
We should just fix the generator instead (and use tree-sitter for parsing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Ran the
const_generator.pyto generate python bindings.Changed the comment placement in a few places because the generator wasn't able to parse them and it resulted in the RHS being left blank
Test plan
No tests added. All tests pass
Closing issues
none