x86: fix access metadata for EVEX writemasks - #3059
Open
raaller wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
EVEX writemasks are exposed by the x86 printers as additional "cs_x86_op" operands, while the instruction access table describes only the non-writemask semantic operands. Using the public operand position directly therefore shifts the access lookup.
With Intel syntax, operands after the writemask can lose their access metadata. With AT&T syntax, the writemask itself is appended after the semantic operands and receives no access metadata. This change records the operand created from "ENCODING_WRITEMASK" and its corresponding detail-operand position. The printers assign "CS_AC_READ" to that operand and exclude it from the semantic access index. K registers used as regular instruction operands are left unchanged.
Test plan
Added seven regression tests covering:
Closing issues
Closes #2565