Skip to content

Conversation

@Changqing-JING
Copy link
Contributor

@Changqing-JING Changqing-JING commented Jan 6, 2025

Add tricore tc1.8 instructions:

add.df
sub.df
madd.df
msub.df
mul.df
div.df
cmp.df
max.df
min.df
min.f
max.f
dftoi
dftoiz
dftoin
ftoin
dftou
dftouz
dftol
dftoul
dftoulz
abs.f
abs.df
dftolz
neg.df
neg.f
qseed.df
itodf
utodf
ltodf
ultodf
dftof
ftodf
div64
div64.u
rem64
rem64.u

A major change in tc18 instruction encoding is:
The n field can indicate mnemonics for instruction variant with 64bit register operand.
For example 6b 00 21 00 is add.f %d0,%d0,%d0.
6b 00 22 00 is add.df %e0,%e0,%e0

@XVilka
Copy link
Collaborator

XVilka commented Jan 6, 2025

@imbillow could you please take a look?

@Rot127 Rot127 changed the base branch from auto-sync to auto-sync-18 January 6, 2025 19:06
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait for @imbillow review.

Also, please rebase your commit onto the latest auto-sync branch. I just updated it.

@Changqing-JING
Copy link
Contributor Author

Rebased to new auto-sync

@Changqing-JING
Copy link
Contributor Author

Added a bit more instructions

div64
div64.u
rem64
rem64.u

@Changqing-JING
Copy link
Contributor Author

@imbillow This PR was pending for 1 week. Could you help to review it?

@Rot127
Copy link
Collaborator

Rot127 commented Jan 13, 2025

@Changqing-JING @imbillow seems busy these days. But I just discovered, that TriCore was not in the CI test job. Can you add it please (e3a69d5).

Once it is green we can merge it.

@Rot127
Copy link
Collaborator

Rot127 commented Jan 13, 2025

Never mind. Please just rebase and we are go go once it is green.

add.df
sub.df
madd.df
msub.df
mul.df
div.df
cmp.df
max.df
min.df
min.f
max.f
dftoi
dftoiz
dftoin
ftoin
dftou
dftouz
dftol
dftoul
dftoulz
abs.f
abs.df
dftolz
neg.df
neg.f
qseed.df
itodf
utodf
ltodf
ultodf
dftof
ftodf
div64
div64.u
rem64
rem64.u
@Changqing-JING
Copy link
Contributor Author

Branch Rebased

@Rot127 Rot127 merged commit 159c984 into capstone-engine:auto-sync-18 Jan 14, 2025
3 checks passed
@Changqing-JING Changqing-JING deleted the poc/tricore_tc18 branch January 15, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants