Drop MatchByTypeName check in opIsPartOfiPTRPattern #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you please quickly rebase onto the upstream If you have the time it would be awesome if you could regenerate the tables in Capstone again and open a PR there. So we can close the issue. |
Matching by type name can make incorrect assumption of memory operands, when the destnation register and base register share the same type of GPR. Drop this logic for now. This commit fixes the destination register info of load instructions of LoongArch ISA. Fixes capstone-engine/capstone#2700. Co-authored-by: Rot127 <[email protected]>
jiegec
added a commit
to jiegec/capstone
that referenced
this pull request
May 15, 2025
According to capstone-engine#2700, the register info of LoongArch ld/st instructions is wrong. A fix for the issue is proposed for llvm-capstone at capstone-engine/llvm-capstone#79. This commit integrates the fix and regenerates the tables via `ASUpdater -a LoongArch -w -s IncGen`. The case change in LoongArchGenCSOpGroup.inc is also handled. Fixes: capstone-engine#2700
2 tasks
Collaborator
Author
Done! See capstone-engine/capstone#2701 |
jiegec
added a commit
to jiegec/capstone
that referenced
this pull request
May 20, 2025
According to capstone-engine#2700, the register info of LoongArch ld/st instructions is wrong. A fix for the issue is proposed for llvm-capstone at capstone-engine/llvm-capstone#79. This commit integrates the fix and regenerates the tables via `ASUpdater -a LoongArch -w -s IncGen`. The case change in LoongArchGenCSOpGroup.inc is also handled. Fixes: capstone-engine#2700
kabeor
pushed a commit
to capstone-engine/capstone
that referenced
this pull request
May 20, 2025
According to #2700, the register info of LoongArch ld/st instructions is wrong. A fix for the issue is proposed for llvm-capstone at capstone-engine/llvm-capstone#79. This commit integrates the fix and regenerates the tables via `ASUpdater -a LoongArch -w -s IncGen`. The case change in LoongArchGenCSOpGroup.inc is also handled. Fixes: #2700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching by type name can make incorrect assumption of memory operands, when the destnation register and base register share the same type of GPR. Drop this logic for now. This commit fixes the destination register info of load instructions of LoongArch ISA.
Addresses capstone-engine/capstone#2700.