Draft
Conversation
merwok
force-pushed
the
feature/rework-email-tokens
branch
2 times, most recently
from
4eced47 to
888578d
Compare
merwok
force-pushed
the
feature/rework-email-tokens
branch
from
cf07157 to
4eced47
Compare
merwok
force-pushed
the
feature/rework-email-tokens
branch
from
9331606 to
526fd6a
Compare
Co-authored-by: Julien Labonté <julien.labonte3@gmail.com>
merwok
commented
Nov 11, 2018
| user = deserializer.save() | ||
|
|
||
| if self.email_confirmation_class is None: | ||
| raise MissingSetting('email_confirmation_class') |
Contributor
Author
There was a problem hiding this comment.
This check could be moved to SignupView.as_view, so that the problem is visible when the site starts rather than during the first request.
just1602
approved these changes
Nov 11, 2018
just1602
left a comment
just1602
left a comment
There was a problem hiding this comment.
Clean! Je crois que je ferais le changement pour que la validation se fasse dans la méthode as_view() immédiatement, mais sinon c'est cool !
Contributor
Author
|
Agreed on doing this in the same PR! |
merwok
commented
Nov 19, 2018
| except EmailConfirmation.DoesNotExist: | ||
| msg = _('Invalid link') | ||
| except EmailConfirmation.IsExpired: | ||
| # FIXME it's not possible to register with the same email |
There was a problem hiding this comment.
We should check for expired confirmation, but it shouldn't be an error related to a duplicate email, tho? A user shouldn't be able to create an account with an email related to another email, tho ?
Contributor
Author
Contributor
Author
|
Ok so the plan is:
|
Post-release merge
Signed-off-by: dependabot[bot] <support@dependabot.com>
Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
|
This has been open too long. I think the new endpoint should be another ticket. |
merwok
requested review from
gkijko
and removed request for
JulienLabonte and
mathieuhentges
gkijko
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38