Open
Conversation
|
@OpeAbidemi is attempting to deploy a commit to the Carbon Team on Vercel. A member of the Team first needs to authorize it. |
mfix22
requested changes
Nov 7, 2022
Contributor
mfix22
left a comment
mfix22
left a comment
There was a problem hiding this comment.
Thanks @OpeAbidemi! Just a few questions here and above
Did you confirm that automatic bracket ({}, (), [], …) completion still works correctly?
| @@ -0,0 +1,487 @@ | |||
| import React, { useMemo, useState, useDeferredValue } from 'react' | |||
Contributor
There was a problem hiding this comment.
@OpeAbidemi what is this extra file being used for?
|
|
||
| class Carbon extends React.PureComponent { | ||
| static defaultProps = { | ||
| const Carbon = ( |
Contributor
There was a problem hiding this comment.
Why does this component need to get converted to a functional component? If it isn't strictly required for upgrading to React@18, can we do these changes in a separate PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1360
@mfix22