feat: add new header config#950
Open
ethanwinters wants to merge 4 commits intocarbon-design-system:components-ga-integrationfrom
Open
feat: add new header config#950ethanwinters wants to merge 4 commits intocarbon-design-system:components-ga-integrationfrom
ethanwinters wants to merge 4 commits intocarbon-design-system:components-ga-integrationfrom
Conversation
9 tasks
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
9b5ba1c to
485afd6
Compare
Co-authored-by: Anna Wen <54281166+annawen1@users.noreply.github.com> Co-authored-by: carbon-bot <carbon@us.ibm.com> Co-authored-by: Warren Blood <69060697+warrenmblood@users.noreply.github.com> Co-authored-by: tom-youd <56865994+tom-youd@users.noreply.github.com> Co-authored-by: Warren Blood <blood.warren@gmail.com>
…ign-system#973) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
485afd6 to
74acb69
Compare
74acb69 to
1d0191b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #801 #698 #628 #726
IMPORTANT
We need #955 before we can merge into main.
Add actions and fixed actions to chat header
This PR refactors the chat header component to support custom action buttons and implements a new focus management pattern for web components. It now uses the toolbar component.
Changelog
New
ChatHeaderConfig.actionsproperty@carbon/ai-chat-componentschat header web component (cds-aichat-chat-header) with React wrapperrequestFocus()method pattern for web components to enable parent components to request focus without knowing internal structuredocs/focus-management-pattern.mdexplaining the reusable focus management patternBusEventHeaderMenuClick,HeaderMenuClickType)packages/ai-chat-components/src/globals/scss/component-reset.scsschat-header.test.ts) with 471 lines of testsChanged
packages/ai-chat/src/chat/components-legacy/header/) to new modular header component (packages/ai-chat/src/chat/components/header/)ChatHeaderConfiginterface to support action buttons with icons, labels, disabled states, and click handlersRemoved
packages/ai-chat/src/chat/components-legacy/header/Header.tsxpackages/ai-chat/src/chat/components-legacy/header/Header.scssTesting / Reviewing
Functional Testing
Code Review Checklist
ChatHeaderConfiginterface for API designchat-header.tschat-header.test.ts