feat: Carbon carousel implementation#972
feat: Carbon carousel implementation#972davidmenendez wants to merge 6 commits intocarbon-design-system:mainfrom
Conversation
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| }; | ||
|
|
||
| export default { | ||
| title: "Components/Carousel", |
There was a problem hiding this comment.
Lets add it to Preview/Carousel instead for now
| $blockClass: #{$prefix}-carousel; | ||
|
|
||
| .#{$blockClass} { | ||
| &__controls { |
There was a problem hiding this comment.
Maybe throw on the label-02 type style here
ethanwinters
left a comment
ethanwinters
left a comment
There was a problem hiding this comment.
Just a couple of notes
| cards, | ||
| (card) => html` | ||
| <cds-aichat-card> | ||
| <div slot="body">${card}</div> |
There was a problem hiding this comment.
can we just give the content a 1rem body or something
There was a problem hiding this comment.
actually, if you set is-flush to false (or something like that) the card will add the padding automatically
|
|
||
| # Carousel | ||
|
|
||
| It's very good |
There was a problem hiding this comment.
Lets add a real version of this paragraph. I'm guessing you are doing all the "react" version. stuff in a second PR.
There was a problem hiding this comment.
but it's pretty good placeholder 😂
| InitCarousel, | ||
| Config, | ||
| CarouselResponse, | ||
| } from "@carbon/utilities"; |
There was a problem hiding this comment.
Do the carbon utilities deal with a11y? Like marking the carousel items out of view either hidden or inert?
There was a problem hiding this comment.
i'm not sure about this. i'll take a look 👍
There was a problem hiding this comment.
currently it doesn't look like there's anything being done in the current implementation regarding accessibility. things like aria-hidden and aria-live are not being handled directly in the carousel. i can follow up with core to see if this is on their radar and open an issue to address this if it isn't already 👍
|
@ethanwinters confirmed that the accessibility functionality is missing and now there's an issue in core to address it. i'm happy to commit it myself to expedite things 👍 |
2 participants
Closes #643
Adds a new
carouselcomponent to ai-chat components that uses the carbon carouselChangelog
New
cds-aichat-carouselstill a work in progress. just wanted to get some eyes on it before moving forward.