Onboard IBM Telemetry#1874
Onboard IBM Telemetry#1874makafsal wants to merge 17 commits intocarbon-design-system:theiliad-v10-legacyfrom
Conversation
mattrosno
left a comment
There was a problem hiding this comment.
Project IDs and configs look good! I think we just need to uninstall the legacy @carbon/telemetry packages now that they are no longer used in postinstall scripts.
|
It's interesting that |
mattrosno
left a comment
There was a problem hiding this comment.
@IgnacioBecerra @ariellalgilmore this LGTM. I reviewed:
- Project IDs match the IDs used in the master branch
- YML config files have the right scopes and the React config file has the same JSX config as the master branch
- Postinstall scripts
- Readme notices
- The package.json's don't specify "files", so there's no need to include the package.json in those export lists
|
@theiliad I'm not sure if that Mend check can be ignored or not, but the changes in this PR LGTM to instrument the v10 packages. |
|
@mattrosno If there’s anything I need to do on my end, please let me know - I’m happy to help. |
|
@mattrosno @makafsal there isn't an automatic process to make 0.x releases, I will do it manually soon |
|
@theiliad following up as this it still open. Thanks! |
IgnacioBecerra
left a comment
There was a problem hiding this comment.
@makafsal Since we are still in the process of onboarding the v10 charts package with this PR, I attempted to push my own commits here, but due to lacking permissions, I am suggesting changes through a review instead.
We are looking to update the READMEs to the wording of the latest version, and also updating the .yml files so we're using the new stable URL. Let me know if you have any question, thank you!
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
|
@IgnacioBecerra Great, I've committed those changes 🚀. If you have more changes to commit, don't hesitate to ping me in Slack✌️. |
|
@theiliad I believe this is still ready for your review and merge. |
Hi, sorry for the delay, I've had issues with the release. Will resolve very soon |
Updates
packages/core/telemetry.ymlfile@ibm/telemetry-jspackages/core/README.md