fix(dropdown-list): only updateIndex if there's no index yet#3139
Merged
Akshat55 merged 2 commits intocarbon-design-system:masterfrom May 7, 2025
Merged
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Akshat55
approved these changes
May 7, 2025
Akshat55
approved these changes
May 7, 2025
|
🎉 This PR is included in version 5.57.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3138
Upon creation of the dropdown-list, the
getUpdateIndexandgetNextElementget called 4 times, incrementing theindexfor the highlighted element to the 4th item. This is unwanted behavior and this MR fixes itChangelog
Changed