Draft commit for review for Popover v11 #1896#1930
Open
SimpleProgrammingAU wants to merge 1 commit intocarbon-design-system:next/v11-stylesfrom
Open
Draft commit for review for Popover v11 #1896#1930SimpleProgrammingAU wants to merge 1 commit intocarbon-design-system:next/v11-stylesfrom
SimpleProgrammingAU wants to merge 1 commit intocarbon-design-system:next/v11-stylesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a couple hours adopting the CDS React approach to the Popover element and it appears to break the previously working approach in CDS Svelte (i.e. without providing a
PopoverContentcomponent).Please have a quick look at what I've done and let me know if we should lean into what looks like a very breaking change or have I missed something that would allow the existing syntax, as shown in the current CDS Svelte documentation, to work?
Implemented:
idprop (although, I added that months ago and am now wondering if I added that correctly)dropShadowoptioncontainerPropsobjectrelativeprop because it looks like that's forced upon you now (or am I misreading the css?)spanelement rather than adivper CDS ReactcontentPropstoPopoverContentNot yet implemented:
tabTip