fix: address runtime correctness errors#2745
Merged
Conversation
…allbacks - guard breakpointObserver find result before `store.set` - guard breakpointObserver derived callbacks against undefined `$size`
- guard resolvePath pathCache.delete key - guard resolvePath segments before reduce
…RangePlugin` use - add null safety for DOM nodes in createCalendar - guard RangePlugin before use in createCalendar
metonym
force-pushed
the
metonym/ts-fixes
branch
from
d4d7350 to
e857442
Compare
metonym
changed the title
checkJs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used
checkJs: trueto identify and fix many runtime correctness fixes (null/undefined safety) insrc/**/*.jsfiles.matchers.find()result (entry?.[0]) beforestore.set$size !== undefinedin derived callbacks before indexingbreakpointspathCache.delete(firstKey)(segments ?? []).reduce(...)so reduce is never called on undefinedquerySelector(...)?.classListandparentNode?.replaceChilddaysContainer; initializeRangePluginand onlynew RangePlugin(...)when defined (mode === "range")options?.clampin actionupdate()so Svelte can callupdate()with no args