Fix/7579 toc scroll console error#12433
Merged
kodiakhq[bot] merged 28 commits intocarbon-design-system:mainfrom Mar 3, 2026
Merged
Fix/7579 toc scroll console error#12433kodiakhq[bot] merged 28 commits intocarbon-design-system:mainfrom
kodiakhq[bot] merged 28 commits intocarbon-design-system:mainfrom
Conversation
This reverts commit bca35cb.
…-dotcom into fix/7579-toc-scroll-console-error
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marcelojcs
approved these changes
Mar 3, 2026
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8d211be
into
carbon-design-system:main
16 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-8128
Description
The calculation that the ToC component does to map all the sections of the page and link them to the ToC's buttons was also being called on pages without the ToC enabled. That was causing the property 'position' to be undefined due to ToC trying to compute multiple items but only finding one, resulting in multiple of these errors in the console:
Changelog
added some conditions to validate if there are enough elements to trigger the calculations.