Conversation
I'll ammend this later
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 1 out of 2 committers have signed the DCO. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Description:
Cloned the whole video-player to a video-player-v7 tag in order to integrate the new kaltura V7 player as a component;
The idea is to create a new standalone player that respects all existing properties from the previous one in order to keep full compatibility on the consuming componentes (leadspace-with-video, intersection-cards, etc.) - while consuming new endpoints and simplifying the process.
Glossary:
mediacenter-loader: Mediacenter's managed script that will handle the api and embed of the multiple players (video/audio/playlist/reels) available in mediacenter and the streaming platforms;
mediacenter-loader-api: The api functionality within the above script
mediacenter-player-plugin: Mediacenter's managed script that will handle customization and extra functionalities built on top of the out of the box vendor player;
Changelog:
Kaltura Service V7 [packages/services-store/src/actions/kalturaPlayerAPIv7.ts]
Description:
The above 3 parameters were previously hardcoded in the service and expected to always be latest version, public-production env and northstar-player - which are the fallback values if nothing is sent;
The current components will keep not passing a value to the service and falling back to default values;
The reason to this change is that in the near future, we're able to enhance this section without breaking anything;
Description:
The thumbnail url string was processed within the service, now it just expect whatever value the mediacenter-loader-api returns;
Description:
The service used to do a complex request to the player api regarding media properties and store the answer as an object in itself (in memory);
Now it just expect (with a simple call) whatever value the mediacenter-loader-api returns;
The mediacenter-loader-api also cache the request in memory;
Description:
Those two functionalities did the same exact thing through different ways, one use the v2 player api (that used INTL behind the scenes), the other used INTL directly;
And all three were not being used - as the components favored another function that did the same processing with extra information called formatVideoDuration inside
utilities/src/utilities/formatVideoCaption/formatVideoCaption.js;This was utter nonsense!
Description:
As agreed, the metrics portion of the player will be handed by the mediacenter-player-plugin and not the carbon-web-component anymore;
Description:
Removed the metrics section (as part of the previous item);
Kept the legacy "fake promisse" handling for the not promise-type response from V2 player;
Offloaded many configuration properties to simpler terms, like "playerType: background" instead of manually turning off the closed-captions, title-menu, controls, call-to-actions and other options;
Incorporated the first 3 items (environment, partner-id and player-uiconfid);
Left for future enhancement the place where the different player-types will change configuration settings;
Cloned all the player files
Notes:
I've found some interesting behavior in the "AutoPlay" functionalities described in this video;
And also found something very interesting in the V2 component - that I just passed over to V7 although I didn't like it:
[ Link ]
Basically if the video gets the title changed, it will only show IF the page locale is english, wich absolutely defeat the purpose of having that property available for translation.