Generate AST when importing a cpp file #4790
Conversation
Ignore the AST, for now. Report cpp compilation errors and warnings. Part of carbon-language#4666
danakj
left a comment
danakj
left a comment
There was a problem hiding this comment.
a couple suggestions and questions
toolchain/check/testdata/interop/cpp/no_prelude/file_not_found.carbon
Outdated
Show resolved
Hide resolved
jonmeow
left a comment
jonmeow
left a comment
There was a problem hiding this comment.
This is great!
I'm looking at this, and thought of a lateral issue... We're fuzz testing, and as soon as the fuzzer discovers it can write C++ imports we'll end up fuzz testing Clang, and Clang is not crash-resilient. The driver already has a DriverEnv::fuzzing flag, can you have it lead to an error when set and importing from Cpp?
1. Change diagnostic ids. 2. Split file read error into a note. 3. Added bad import Cpp tests. 4. Remove `is_cpp` and move the condition higher.
bricknerb
changed the title
…o import Cpp files.
I've added an error for that. |
toolchain/check/testdata/interop/cpp/no_prelude/bad_import.carbon
Outdated
Show resolved
Hide resolved
toolchain/check/testdata/interop/cpp/no_prelude/bad_import.carbon
Outdated
Show resolved
Hide resolved
toolchain/check/testdata/interop/cpp/no_prelude/bad_import.carbon
Outdated
Show resolved
Hide resolved
3 participants
Ignore the AST and support a single Cpp import, for now.
Report cpp compilation errors and warnings.
Part of #4666