Skip to content

Update Documentation to use new expression terminology #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

evoxtorm
Copy link

Changes

Terminology Updates

This PR updates documentation to align with the expression phase terminology changes introduced in #2964:

  • "symbolic value" → "symbolic constant": Updated all remaining instances using find-and-replace
  • "constant" → "template constant": Updated instances where "constant" was used in the old definition (referring to compile-time constants that can participate in template contexts)

Scope of Changes

  • Focused on documentation that predates the July 2023 terminology change
  • Used git blame history to identify instances likely using the old "constant" definition
  • Manually reviewed each "constant" usage to distinguish between:
    • Old definition (now "template constant"): compile-time constants with special evaluation rules
    • New definition (unchanged): the broader category including both template constants and symbolic constants

Closes #5599

Copy link

google-cla bot commented Jul 31, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added documentation An issue or proposed change to our documentation toolchain labels Jul 31, 2025
@evoxtorm evoxtorm marked this pull request as ready for review July 31, 2025 12:23
@github-actions github-actions bot requested review from chandlerc and danakj July 31, 2025 12:23
Copy link
Contributor

@danakj danakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a first pass, a lot of the changes from "constant" look incorrect as they are referring to "compile time values" aka both template and symbolic constants I think. The "symbolic value" -> "symbolic constant" looks pretty straightforward though.

I would like @chandlerc to give this a review as well.

Copy link
Contributor

@geoffromer geoffromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the subtleties here (particularly around "symbolic value"), I think it'd be a good idea to get a review from @josh11b and/or @zygoloid, who are more familiar with this area than I am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or proposed change to our documentation toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to reflect new expression phase terminology
4 participants