Create Clang type sugar matching Carbon type names. #6103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zygoloid
force-pushed
the
toolchain-clang-type-names
branch
from
03c2d7a to
77804e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a Clang type corresponding to a Carbon type, create a fake Clang typedef whose name matches the Carbon type's name so that Clang diagnostics name the type using the Carbon name. Clang will also produce an
akadescribing the corresponding C++ type.TODO: Figure out a way to effectively cache the typedefs and avoid computing a string representation and allocating a separate typedef declaration for every call argument before merging.