Allow interop with classes with virtual base classes. #6413
+321
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, treat such classes as being final, since we can't correctly derive from them.
josh11b
reviewed
Nov 20, 2025
Comment on lines
53
to
54
| // This should construct a 40-byte object, using the `...C1` constructor, | ||
| // which should call the `...C2` constructors for A, B, and C. |
Contributor
There was a problem hiding this comment.
What are "C1" and "C2" here? Or link to an explanation?
Contributor
Author
There was a problem hiding this comment.
Expanded comment a bit to try to explain.
I looked for a link with an explanation, but the ABI document doesn't really have a good place that explains this :(
josh11b
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, treat such classes as being final, since we can't correctly derive from them.
This removes the last category of C++ class that we are entirely unable to interop with, and is a prerequisite for interop with C++ iostreams (which have a virtual base class).