Add basic testing of libunwind.a runtimes build #6417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds the archive and checks relevant symbols are defined. While here, this refactors the runtimes test to share much more code between the different runtimes. Last but not least, this adds a convenience type-def for the libunwind runtimes builder. There is an inconsistency between how we spell things as `Libunwind` or `LibUnwind`. We should canonicalize on the former as it matches the underscores and other things we will spell in this space. I'm not fixing existing spellings in this PR but will send follow-ups for those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds the archive and checks relevant symbols are defined. While here, this refactors the runtimes test to share much more code between the different runtimes.
Last but not least, this adds a convenience type-def for the libunwind runtimes builder.
There is an inconsistency between how we spell things as
LibunwindorLibUnwind. We should canonicalize on the former as it matches the underscores and other things we will spell in this space. I'm not fixing existing spellings in this PR but will send follow-ups for those.