Switch llvm-raw to a git_override rule#6854
Merged
chandlerc merged 2 commits intocarbon-language:trunkfrom Mar 7, 2026
Merged
Conversation
Assisted-by: Google Antigravity with Gemini
Assisted-by: Google Antigravity with Gemini
jonmeow
force-pushed
the
llvm-git-override
branch
from
8212b0a to
6f288c5
Compare
geoffromer
reviewed
Mar 7, 2026
Contributor
geoffromer
left a comment
geoffromer
left a comment
There was a problem hiding this comment.
LGTM but I'm not sure I fully understand the ramifications of this, so I'd prefer if someone like @chandlerc could approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using git_override, we get some validation from the sha, while removing the sha256 on the .tar.gz which has been brittle lately. Note the difference between downloading via sha is this still locally validates content.
Versus something like #6844, this doesn't update the llvm version, just how we get it.
Assisted-by: Google Antigravity with Gemini