Skip to content

feat(rust/signed-doc): Add chain field metadata validation rule#573

Merged
apskhem merged 34 commits intomainfrom
feat/chain-rule-validator
Oct 17, 2025
Merged

feat(rust/signed-doc): Add chain field metadata validation rule#573
apskhem merged 34 commits intomainfrom
feat/chain-rule-validator

Conversation

@apskhem
Copy link
Collaborator

@apskhem apskhem commented Sep 24, 2025

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

Closes #539

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Sep 24, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Sep 24, 2025
@apskhem apskhem linked an issue Sep 24, 2025 that may be closed by this pull request
@apskhem apskhem added the draft Draft label Sep 24, 2025
@apskhem apskhem added this to Catalyst Sep 24, 2025
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Sep 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Test Report | ${\color{lightgreen}Pass: 527/527}$ | ${\color{red}Fail: 0/527}$ |

@apskhem apskhem marked this pull request as draft September 24, 2025 16:23
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont forget to also implement ChainRule::new method for initialisation of the ChainRule from the DocSpecs

@apskhem apskhem marked this pull request as ready for review October 10, 2025 17:17
@apskhem apskhem requested a review from Mr-Leshiy October 10, 2025 17:33
@apskhem apskhem added the review me PR is ready for review label Oct 10, 2025
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Oct 10, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Oct 14, 2025
@apskhem apskhem requested a review from Mr-Leshiy October 14, 2025 09:00
@apskhem apskhem moved this from 🔖 Ready to 🏗 In progress in Catalyst Oct 14, 2025
@apskhem apskhem moved this from 🏗 In progress to 👀 In review in Catalyst Oct 14, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Oct 16, 2025
@apskhem apskhem moved this from 🔖 Ready to 👀 In review in Catalyst Oct 16, 2025
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apskhem apskhem merged commit 7aa7eaf into main Oct 17, 2025
25 checks passed
@apskhem apskhem deleted the feat/chain-rule-validator branch October 17, 2025 06:24
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ChainRule validation rule type

2 participants