Draft
Conversation
curiecrypt
commented
Oct 9, 2024
| } | ||
|
|
||
| // Test: Empty polynomials | ||
| proptest! { |
Author
There was a problem hiding this comment.
For the record
@perturbing We might want to cover the case for empty polynomials in
fft_mul, since we get the following fail:thread 'tests::test_fft_mul_empty_polys' panicked at src/lib.rs:201:5: Test failed: assertion failed: `(left == right)` left: `[]`, right: `[Scalar(0x0000000000000000000000000000000000000000000000000000000000000000)]`: Failed on case left = empty, right = non-empty with right.len() = 1 at src/lib.rs:209. minimal failing input: non_empty_vec = [ Scalar(0x0000000000000000000000000000000000000000000000000000000000000000), ] successes: 0 local rejects: 0 global rejects: 0
Yeah, sounds good.
It's also a balance between safety and speed. In the code as it is now, I highly favored speed and less complexity.
But we can also make the interface safer, in that we introduce a type for a polynomial and create an interface where polynomials are always normalized and no trailing zero's etc. Then the zero is uniquely the empty list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the
proptests. Tests cover the following cases:fft_mulget_coeff_from_rootsget_poly_commitment_g1Closes #1