approach-3: Set outgoing accountable in process_pending_forwards #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this approach, we just copy the incoming signal in
process_pending_forwards, rather than setting it inforward_htlcs. This has the advantage of not needing to store ouroutgoing_accountablesignal anywhere, as we have theincoming_accountablesignal on hand.I like the flexibility of this approach in particular, because we have some flexibility:
forward_htlcs, we can just add it toPendingHtlcRoutingprocess_pending_forwards, then we're good to go