-
Notifications
You must be signed in to change notification settings - Fork 1
feat(AuthCallbackHandler): Add a OAuthCallback Handler instance that can be used already build in #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…an be already used build in Made the Handler specific Methods that use magic numbers (status, messages...) virtual so someone who would like to have other behavior could simply override them and implement it with littlest effort Added ErrorResponse Default uri key names of the official standard document and implemented in the OAuthCallbackHandler
TODO: Decide which of both Query checking Methods should be used
|
Updated to seperate Project and latest Registration Changes implemented for AuthCallbackHandler
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds OAuth callback handler functionality to the Yllibed HTTP server library by creating a new Yllibed.Handlers.Uno project. The implementation provides a built-in handler for OAuth authentication callbacks that integrates with Uno.UI's WebAuthenticationResult.
Key changes:
- Creates a new
OAuthCallbackHandlerclass that implements OAuth callback processing - Adds dependency injection extensions for easy service registration
- Implements OAuth error response handling according to RFC 6749 standards
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates SDK configuration to include Uno.Sdk 6.2.29 |
| Yllibed.Handlers.Uno/OAuthCallbackHandler.cs | Main OAuth callback handler implementation with status code mapping and result processing |
| Yllibed.Handlers.Uno/IAuthCallbackHandler.cs | Interface definition for authentication callback handlers |
| Yllibed.Handlers.Uno/Extensions/OAuthCallbackExtensions.cs | Dependency injection extensions for registering OAuth callback handlers |
| Yllibed.Handlers.Uno/Extensions/UriExtensions.cs | URI parameter parsing utilities for OAuth callback processing |
| Yllibed.Handlers.Uno/Defaults/OAuthErrorResponseDefaults.cs | OAuth error response constants based on RFC 6749 |
| Yllibed.Handlers.Uno/AuthCallbackHandlerOptions.cs | Configuration options for the auth callback handler |
| Yllibed.Handlers.Uno/Yllibed.Handlers.Uno.csproj | Project file for the new Uno handlers library |
Comments suppressed due to low confidence (1)
Yllibed.Handlers.Uno/OAuthCallbackHandler.cs:1
- This large commented-out code block should be removed rather than left as dead code. If this implementation might be needed later, consider documenting the decision in a comment or tracking it in an issue.
using Microsoft.Extensions.DependencyInjection;
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…nt xunit.runner.json configured usage
|
Aligned with GuardExtensions, removed Keyed usage. While this could be a good addition, in case the user has multiple handlers needed and wants to use named options, it's more complicated since |
…ed Readme config for Handlers
… 15 on httpserver-origin repo is handled in any way
|
Note
|
…verload succeeds to initialize using the known generic action pattern
…ndler with the expected Interface
…tication.WinUI Package, not the unrequired transient dependencies too
…o simplify transfer to AuthCallbackHandlerOptions
…etting respected and should not get recommended then
TODO: Check if there is any non Uno.UI specific replacement for the
WebAuthenticationResultwith similar/same end result, to fix the type not found lintings?Made the Handler specific Methods that use magic numbers (status, messages...) virtual so someone who would like to have other behaviour could simply override them and implement it with littlest effort
Added ErrorResponse Default uri key names of the official standard document and implemented in the OAuthCallbackHandler