chore(deps): add net10.0 to TargetFrameworks and solve NU1510 warnings #16
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionally include platform packages
…for given Target Frameworks - Removed System.ValueTuple from Solution - Removed System.Diagnostics.DiagnosticSource only from Projects (tests), which don't even target legacy netstandard2.0 - build passed - Test Passes, but netstandard 2.0 seems to have no test coverage, alternative Validation options?
There was a problem hiding this comment.
Pull Request Overview
This PR adds .NET 10.0 as a target framework across all projects in the solution and resolves NU1510 NuGet warnings by removing package references that are no longer needed for the targeted frameworks.
Key Changes:
- Added
net10.0to TargetFrameworks in all four project files (two library projects and two test projects) - Removed
System.ValueTuplepackage reference completely, as it's included in the BCL for all targeted frameworks (netstandard2.0 and above) - Removed
System.Diagnostics.DiagnosticSourcepackage reference from test projects that only target net9.0 and net10.0 where it's part of the framework - Updated CI/CD workflow to install .NET 10.0 SDK
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Yllibed.HttpServer/Yllibed.HttpServer.csproj | Added net10.0 to TargetFrameworks and removed System.ValueTuple package reference from netstandard2.0 conditional group |
| Yllibed.HttpServer.Tests/Yllibed.HttpServer.Tests.csproj | Added net10.0 to TargetFrameworks and removed unnecessary System.Diagnostics.DiagnosticSource and System.ValueTuple package references |
| Yllibed.HttpServer.Json/Yllibed.HttpServer.Json.csproj | Added net10.0 to TargetFrameworks |
| Yllibed.HttpServer.Json.Tests/Yllibed.HttpServer.Json.Tests.csproj | Added net10.0 to TargetFrameworks and removed unnecessary System.Diagnostics.DiagnosticSource and System.ValueTuple package references |
| Directory.Packages.props | Removed System.ValueTuple package version definition as it's no longer needed |
| .github/workflows/build.yml | Added .NET 10.0 SDK setup step to support building and testing with the new target framework |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net10.0to allTargetFrameworksof Project filesRemoved
System.ValueTuplecompletly from Solution to get rid of the warningIf this turns out to be required, the
NU1510will need to be added as NoWarn.Tryed setting
NoWarnor/andPackageReferenceConditionally to TargetFramework but VS2026 kept Issuing it stillRemoved
System.Diagnostics.DiagnosticSourceonly from Projects (tests), which don't even target legacynetstandard2.0local Build passed
Tests passed
Warning
netstandard2.0 seems to have no test coverage, alternative Validation options to consider?