Introduce DI support and customizable server options #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added dependency injection extensions for `Server` registration. - Introduced `ServerOptions` for configurable server settings (port, hostname, bind address). - Refactored `Server` constructors to support `ServerOptions`. - Updated tests to validate DI and `ServerOptions` functionality. - Simplified namespace declarations with file-scoped syntax.
carldebilly
force-pushed
the
dev/di-supported-config
branch
from
1a32155 to
127bdf8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dependency injection support and configurable server options to the Yllibed.HttpServer project, making it more suitable for modern .NET applications with DI containers.
Key changes include:
- Added
ServerOptionsclass for configurable server settings including port, hostname, and bind addresses - Introduced DI extension methods for easy
Serverregistration with service collections - Refactored
Serverconstructors to support both directServerOptionsandIOptions<ServerOptions>patterns
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Yllibed.HttpServer/Yllibed.HttpServer.csproj | Added PolySharp package reference and InternalsVisibleTo attribute |
| Yllibed.HttpServer/ServerOptions.cs | New configuration class with port, bind addresses, and hostname settings |
| Yllibed.HttpServer/Server.cs | Refactored constructors to support ServerOptions and added DI-friendly constructor |
| Yllibed.HttpServer/Extensions/ServiceCollectionExtensions.cs | New DI extension methods for server registration |
| Yllibed.HttpServer/Server.HttpServerRequest.cs | Minor cleanup removing unused field |
| Multiple test files | Added comprehensive tests for DI scenarios and ServerOptions functionality |
| Documentation files | Updated README with extensive DI and configuration examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+47
to
52
| private sealed class MyJsonHandler : JsonHandlerBase<MyResultPayload> | ||
| { | ||
| public MyJsonHandler(string method, string path) : base(method, path) | ||
| { | ||
| public string? A { get; set; } | ||
| public string? B { get; set; } | ||
| } | ||
|
|
There was a problem hiding this comment.
[nitpick] The constructor change from primary constructor syntax to explicit constructor appears to be a regression. Consider keeping the more concise primary constructor syntax: private sealed class MyJsonHandler(string method, string path) : JsonHandlerBase<MyResultPayload>(method, path)
Suggested change
| private sealed class MyJsonHandler : JsonHandlerBase<MyResultPayload> | |
| { | |
| public MyJsonHandler(string method, string path) : base(method, path) | |
| { | |
| public string? A { get; set; } | |
| public string? B { get; set; } | |
| } | |
| private sealed class MyJsonHandler(string method, string path) : JsonHandlerBase<MyResultPayload>(method, path) | |
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces dependency injection support and configurable server options to the Yllibed.HttpServer project. The changes make the server more flexible and suitable for modern .NET applications with DI containers.
Closes #6
Serverregistration.ServerOptionsfor configurable server settings (port, hostname, bind address).Serverconstructors to supportServerOptions.ServerOptionsfunctionality.