Update Go version for Docker file carlosedp/golang to 1.23.6#51
Open
danielboven wants to merge 1 commit intocarlosedp:masterfrom
Open
Update Go version for Docker file carlosedp/golang to 1.23.6#51danielboven wants to merge 1 commit intocarlosedp:masterfrom
danielboven wants to merge 1 commit intocarlosedp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Docker image
carlosedp/golangis quite extensively used by other Docker images (in the build process). For instance, theshenxn/protonmail-bridgerelies on the Go image to build the mail bridge.For them to be updated, the
carlosedp/golangshould be bumped to a newer version of Go. I have made small changes to theDockerfile.golangto allow updating to Go version 1.23.6. I have tested this with success on two different architectures.Changelog
VERvariable to1.23.6.Dockerfile.golangas these were using an outdated format. This prevents the Docker warningLegacyKeyValueFormat.Small request
If @carlosedp approves this pull request, would you mind updating the Docker image on the container registry (using the command outlined in the top of the
Dockerfile.golang)? Thanks in advance!