small advices for all projects in TypeScript#1
Open
ardiadrianadri wants to merge 6 commits intocarlospalacin:masterfrom
Open
small advices for all projects in TypeScript#1ardiadrianadri wants to merge 6 commits intocarlospalacin:masterfrom
ardiadrianadri wants to merge 6 commits intocarlospalacin:masterfrom
Conversation
…he js and map files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1- The map and js files are files generated by the compilation task. You should configure your .gitignore to avoid to commit them
2- If you use bower, don't forget to add the bower_component folder to your .gitignore. The bower dependencies can be download from the bower repository. It is no need to add them in git
3- If you want to share your projects with other configure the npm task in the right way. Npm install should install all the dependencies (npm, bower, typings, etc...) and npm start should start the app. In this case you've forgotten to add the bower install after the npm install
4- When you share you code don't add clases and libraries that are not used. It makes your code more difficult to understand
5- When you share you code, the best practice, is to write all your literals in english to make your app understandable for the great majority of the community.
And that's all. The rest is nice.