Skip to content

Introduced protections against XXE attacks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Introduced protections against XXE attacks #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...modder-plugin-maven/src/main/java/io/codemodder/plugins/maven/operator/FormatCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.codemodder.plugins.maven.operator;

import static io.github.pixee.security.XMLInputFactorySecurity.hardenFactory;
import java.io.ByteArrayInputStream;
import java.io.IOException;
import java.io.InputStream;
Expand Down Expand Up @@ -35,7 +36,7 @@ class FormatCommand extends AbstractCommand {
private static final Logger LOGGER = LoggerFactory.getLogger(FormatCommand.class);

/** StAX InputFactory */
private XMLInputFactory inputFactory = XMLInputFactory.newInstance();
private XMLInputFactory inputFactory = hardenFactory(XMLInputFactory.newInstance());

/** StAX OutputFactory */
private XMLOutputFactory outputFactory = XMLOutputFactory.newInstance();
Expand Down Expand Up @@ -529,7 +530,7 @@ private byte[] serializePomFile(POMDocument pom) throws XMLStreamException {
*
* <p>Grab the same initial offset from the formatted element like we did
*/
XMLInputFactory inputFactory = XMLInputFactory.newInstance();
XMLInputFactory inputFactory = hardenFactory(XMLInputFactory.newInstance());
XMLEventReader eventReader =
inputFactory.createXMLEventReader(
new ByteArrayInputStream(xmlRepresentation.getBytes(pom.getCharset())));
Expand Down