Skip to content
This repository was archived by the owner on Sep 28, 2025. It is now read-only.

Conversation

@Aandree5
Copy link
Contributor

Description

Not sure why this was commented out, but I was getting an issue where I was filtering an M3U file and then deleted the file, after I could not remove the filer because the option for that file was no longer available.

Type of Change

  • New feature (non-breaking change which adds functionality)

Testing Instructions

  • Steps to reproduce/test the changes
  1. Add 2 M3U files
  2. Filter streams list by file 1
  3. Remove file 1
  4. No longer possible to see any stream because is still filtering file 1
  • Expected behaviour
    Selection to disappear automatically or allow to clear all

Visual Changes

  • Screenshots/videos attached

image

Checklist

  • I have followed the Conventional Commits naming convention
  • My branch is up to date with the main branch (rebased)
  • My code follows the style guidelines and existing patterns of this project
  • I have performed a self-review of my own code
  • I have commented complex logic
  • All tests are passing

Copy link
Owner

@carlreid carlreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊

Not sure why this was commented out

There's a lot commented out both UI and backend. My only guess is that the point in time we managed to restore to, was mid release or something.

Though a lot of commented out code is likely removable too.

@carlreid carlreid force-pushed the dropdown-clear-button branch from 0871f27 to 6a5c169 Compare February 24, 2025 14:35
@carlreid carlreid merged commit 033d54b into carlreid:main Feb 24, 2025
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants