Skip to content

Change rendering of fields in list and detail templatetags#56

Merged
carltongibson merged 3 commits intocarltongibson:mainfrom
joshuadavidthomas:stringify-fk
Jul 3, 2025
Merged

Change rendering of fields in list and detail templatetags#56
carltongibson merged 3 commits intocarltongibson:mainfrom
joshuadavidthomas:stringify-fk

Conversation

@joshuadavidthomas
Copy link
Contributor

@joshuadavidthomas joshuadavidthomas commented Jul 24, 2024

closes #41

No tests yet.

@johnchrisnew
Copy link

Hi, when will this be included in the main version?

@joshuadavidthomas
Copy link
Contributor Author

Well, it needs tests first off. And a rebase to the current main branch. And a 👍 from Carlton that he is good with merging this in.

@carltongibson
Copy link
Owner

It seems reasonable yes. 👍

@marciomazza
Copy link

We made basically the same in an internal fork.
It would be great to have this merged and released.

@carltongibson
Copy link
Owner

Just for interest, I'm happy to have this change with some tests but, I thought I'd post why it's not something I've needed to fix myself yet.

Namely, I don't stick very long with the default templates when building out.

Rather I get the model on the page and then dive into the view I want to build.

I don't really see Neapolitan as an admin replacement so general purpose templates aren't my priority. Not to say we can't make them better, just that's why they're as they are.

Total aside. 😊

@joshuadavidthomas joshuadavidthomas marked this pull request as ready for review June 11, 2025 21:17
@joshuadavidthomas
Copy link
Contributor Author

joshuadavidthomas commented Jun 11, 2025

Only took me 11 months to add tests... 😅

Let me know if you want me to update the CHANGELOG as well.

@carltongibson carltongibson changed the title change rendering of fields in list and detail templatetags Change rendering of fields in list and detail templatetags Jul 3, 2025
Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's have it. 👍

@carltongibson carltongibson merged commit b1b12b5 into carltongibson:main Jul 3, 2025
12 checks passed
@carltongibson
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fields that are ForeignKeys to other models render as pk, not as the string representation of that model

4 participants