Fix filterset to be unbound when no GET parameters are passed#81
Closed
marciomazza wants to merge 1 commit intocarltongibson:mainfrom
Closed
Fix filterset to be unbound when no GET parameters are passed#81marciomazza wants to merge 1 commit intocarltongibson:mainfrom
marciomazza wants to merge 1 commit intocarltongibson:mainfrom
Conversation
Owner
|
Hi @marciomazza — thanks for the PR.
Can you explain your use-case in more detail please? I have a suspicion this isn't the change you're looking for, but I'd like to hear your side of it fully first. Thanks. |
Author
|
Oh... never mind. I was trying set an initial value on a Filterset's field doing the following. Now I realize it doesn't work, even with this PR: class EventFilter(django_filters.FilterSet):
date = django_filters.DateFilter(
field_name="event_date",
widget=forms.DateInput(attrs={"type": "date"}),
initial=date.today,
)
class Meta:
model = Event
fields = ["date"]This, though, works (without the PR): class EventFilter(django_filters.FilterSet):
date = django_filters.DateFilter(
field_name="event_date",
widget=forms.DateInput(attrs={"type": "date"}),
)
class Meta:
model = Event
fields = ["date"]
def __init__(self, data=None, *args, **kwargs):
if not data:
data = {"date": date.today()}
super().__init__(data, *args, **kwargs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the filterset to be unbound on a request with no get parameters.
This is necessary to set the filterset's (and it's form) initial values.
See
https://github.com/carltongibson/django-filter/blob/635343ec55c9928bfa297314711df77fa83ff6c7/django_filters/filterset.py#L198