Skip to content

Running tests against supported Python versions (#83)#84

Merged
carltongibson merged 1 commit intocarltongibson:mainfrom
dennisstritzke:python-compatibility
Apr 30, 2025
Merged

Running tests against supported Python versions (#83)#84
carltongibson merged 1 commit intocarltongibson:mainfrom
dennisstritzke:python-compatibility

Conversation

@dennisstritzke
Copy link
Contributor

Issue #83 points to a GitHub action failing, because the current Django main requires Python >= 3.12.

This PR assumes that we not only want to have a passing pipeline, but rather a Django / Python compatibility guarantee for Neapolitan.

  • Therefore, I took the compatibility note of django-filter and kept everything but the DRF reference.
  • Changed the matrix to the current Django LTS and corresponding Python version,
  • but ditched Python 3.9 (for Django 4.2) as it would require us to remove the beautiful match statements and is eol in October anyways. (No further changes would be required to support Python 3.9)
  • No Python (deprecation) warnings need to be addressed.

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good bar the one comment. Thanks.

README.rst Outdated
Neapolitan uses a two-part CalVer versioning scheme, such as ``23.7``. The first
number is the year. The second is the release number within that year.

On an on-going basis, Django-Filter aims to support all current Django
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably say Neapolitan here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... Changed to Neapolitan.

Copy link
Owner

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carltongibson carltongibson linked an issue Apr 30, 2025 that may be closed by this pull request
@carltongibson carltongibson merged commit 4efd252 into carltongibson:main Apr 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Python <3.12 in CI for Django main.

2 participants