Skip to content

Add new FlexBE states for TF lookup, laser mapping and TF offset #2

Open
sambertibus99 wants to merge 1 commit intomainfrom
skoehler/expactedPos
Open

Add new FlexBE states for TF lookup, laser mapping and TF offset #2
sambertibus99 wants to merge 1 commit intomainfrom
skoehler/expactedPos

Conversation

@sambertibus99
Copy link

Summary

  • Add FindTF state to lookup transforms between frames
  • Add MapperState (estimate_pose) for laser line segment detection with TF output
  • Add GenericToggleServiceState to toggle any ROS2 service with a boolean field
  • Add EstimatedPoseState Applies an X and Y offset to an input_transform and outputs the
    resulting pose

Copy link

@zhenyan2001 zhenyan2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@sambertibus99 sambertibus99 force-pushed the skoehler/expactedPos branch 3 times, most recently from 18448fe to 6d2f0aa Compare February 1, 2026 12:47
Add new states:
- estimate_pose: pose estimation state
- find_tf: TF lookup state
- generic_service_toggle_state: toggle generic services
- mapper_state: mapping functionality

Update existing states and behaviors for improved functionality.
Fix pre-commit issues and update configuration files.
Copy link
Contributor

@MatteoTschesche MatteoTschesche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noch nicht ganz durch

remapping={'angle': 'angle_degrees', 'duration': 'duration'})
OperatableStateMachine.add(
"Rotate Turtle State",
RotateTurtleState(timeout=10, action_topic="/turtle1/rotate_absolute"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turtle? sounds like some tutorial stuff, this is generated but it should have been copied from somewhere

license='TODO: License declaration',
tests_require=['pytest'],
maintainer="phil",
maintainer_email="philsplus@gmail.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change this file more to show that we did the behavior

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant as a helper function, right? We should maybe give those a specific prefix like: helper_estimate_pose
Also estimate pose sounds like the object tracking is used in some way. Maybe a more fitting name is needed like move_tf, from what I understand from the skill.
therefore: helper_move_tf.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for this one? I would delete it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants