Add new FlexBE states for TF lookup, laser mapping and TF offset #2
Add new FlexBE states for TF lookup, laser mapping and TF offset #2sambertibus99 wants to merge 1 commit intomainfrom
Conversation
d7f3555 to
f12e9e4
Compare
18448fe to
6d2f0aa
Compare
Add new states: - estimate_pose: pose estimation state - find_tf: TF lookup state - generic_service_toggle_state: toggle generic services - mapper_state: mapping functionality Update existing states and behaviors for improved functionality. Fix pre-commit issues and update configuration files.
6d2f0aa to
3e63c7a
Compare
MatteoTschesche
left a comment
There was a problem hiding this comment.
noch nicht ganz durch
| remapping={'angle': 'angle_degrees', 'duration': 'duration'}) | ||
| OperatableStateMachine.add( | ||
| "Rotate Turtle State", | ||
| RotateTurtleState(timeout=10, action_topic="/turtle1/rotate_absolute"), |
There was a problem hiding this comment.
Turtle? sounds like some tutorial stuff, this is generated but it should have been copied from somewhere
| license='TODO: License declaration', | ||
| tests_require=['pytest'], | ||
| maintainer="phil", | ||
| maintainer_email="philsplus@gmail.com", |
There was a problem hiding this comment.
I think we should change this file more to show that we did the behavior
There was a problem hiding this comment.
This is meant as a helper function, right? We should maybe give those a specific prefix like: helper_estimate_pose
Also estimate pose sounds like the object tracking is used in some way. Maybe a more fitting name is needed like move_tf, from what I understand from the skill.
therefore: helper_move_tf.py
There was a problem hiding this comment.
what is the reason for this one? I would delete it
Summary
FindTFstate to lookup transforms between framesMapperState(estimate_pose) for laser line segment detection with TF outputGenericToggleServiceStateto toggle any ROS2 service with a boolean fieldEstimatedPoseStateApplies an X and Y offset to an input_transform and outputs theresulting pose