Skip to content

Health 12/1055 remove auto workout permissions #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iarata merged 3 commits into from
Jan 7, 2025
Merged

Health 12/1055 remove auto workout permissions #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75d0b03
Remove automatically added workout permissions
ciriousjoker Oct 5, 2024
d659be9
Merge pull request #1055 from dieringe/dieringe_health_11.1.0
iarata Jan 7, 2025
80af770
chore: update CHANGELOG.md for breaking change in permission requests…
iarata Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/health/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## 12.0.0

* **BREAKING** (Android) Remove automatic permission request of `DISTANCE_DELTA` and `TOTAL_CALORIES_BURNED` data types when requesting permission for `WORKOUT` health data type.
* For `WORKOUT`s that require above permissions, now those need to be requested manually.
* Fix [#984](https://github.com/cph-cachet/flutter-plugins/issues/984) - PR [#1055](https://github.com/cph-cachet/flutter-plugins/pull/1055)
* Add `LEAN_BODY_MASS` data type [#1078](https://github.com/cph-cachet/flutter-plugins/issues/1078) - PR [#1097](https://github.com/cph-cachet/flutter-plugins/pull/1097)
* The following AndroidManifest values are required to READ/WRITE `LEAN_BODY_MASS`:
```XML
Expand Down
64 changes: 0 additions & 64 deletions packages/health/android/src/main/kotlin/cachet/plugins/health/HealthPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,38 +545,6 @@ class HealthPlugin(private var channel: MethodChannel? = null) :
),
)
}
// Workout also needs distance and total energy burned too
if (typeKey == WORKOUT) {
if (access == 0) {
permList.addAll(
listOf(
HealthPermission.getReadPermission(
DistanceRecord::class
),
HealthPermission.getReadPermission(
TotalCaloriesBurnedRecord::class
),
),
)
} else {
permList.addAll(
listOf(
HealthPermission.getReadPermission(
DistanceRecord::class
),
HealthPermission.getReadPermission(
TotalCaloriesBurnedRecord::class
),
HealthPermission.getWritePermission(
DistanceRecord::class
),
HealthPermission.getWritePermission(
TotalCaloriesBurnedRecord::class
),
),
)
}
}
}
scope.launch {
result.success(
Expand Down Expand Up @@ -630,38 +598,6 @@ class HealthPlugin(private var channel: MethodChannel? = null) :
),
)
}
// Workout also needs distance and total energy burned too
if (typeKey == WORKOUT) {
if (access == 0) {
permList.addAll(
listOf(
HealthPermission.getReadPermission(
DistanceRecord::class
),
HealthPermission.getReadPermission(
TotalCaloriesBurnedRecord::class
),
),
)
} else {
permList.addAll(
listOf(
HealthPermission.getReadPermission(
DistanceRecord::class
),
HealthPermission.getReadPermission(
TotalCaloriesBurnedRecord::class
),
HealthPermission.getWritePermission(
DistanceRecord::class
),
HealthPermission.getWritePermission(
TotalCaloriesBurnedRecord::class
),
),
)
}
}
}
if (healthConnectRequestPermissionsLauncher == null) {
result.success(false)
Expand Down
Loading