Skip to content

Conversation

@anenadic
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 30, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/python-intermediate-development/compare/md-outputs..md-outputs-PR-424

The following changes were observed in the rendered markdown documents:

 12-virtual-environments.md        |  8 ++----
 17-section1-optional-exercises.md | 55 ++++++++++++++++++++-------------------
 md5sum.txt                        |  4 +--
 3 files changed, 32 insertions(+), 35 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-01-30 16:09:33 +0000

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@anenadic anenadic changed the title Update 12-virtual-environments.md Small wording fixes for virtual environments Jan 30, 2025
@anenadic anenadic changed the title Small wording fixes for virtual environments Small wording fixes to ptional exercises Jan 30, 2025
github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@anenadic anenadic changed the title Small wording fixes to ptional exercises Small wording fixes to optional exercises Jan 30, 2025
@anenadic anenadic requested a review from bielsnohr January 30, 2025 16:24
Copy link
Collaborator

@bielsnohr bielsnohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly sensible. Just a few nit-picks but otherwise good to go in.

to customize the command line.
## Optional Exercises

Have a look at [some optional exercises](17-section1-optional-exercises.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Have a look at [some optional exercises](17-section1-optional-exercises.md).
Have a look at [these optional exercises](17-section1-optional-exercises.md) if you have some extra time and want to further explore these concepts.

::::::::::::::::::::::::::::::::::::::: challenge

## Exercise: Customize the command line
## Exercise: Customise the command line tool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the addition of "tool" to help those less familiar with the term? Otherwise, I don't think it is ever something I have referred to as "the command line tool". I would vote for just keep "command line" because that is how we have introduced it in the course already.

Suggested change
## Exercise: Customise the command line tool
## Exercise: Customise the command line

## Exercise: Customise the command line tool

You can customize the command line or use alternatives to `bash` to make yourself more productive.
You can customise the command line tool or use alternatives to `bash`, such as:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can customise the command line tool or use alternatives to `bash`, such as:
You can customise the command line or use alternatives to `bash`, such as:

Copy link
Collaborator

@steve-crouch steve-crouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these @anenadic !

@steve-crouch steve-crouch merged commit 8fcaee8 into main Apr 1, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
Auto-generated via `{sandpaper}`
Source  : 8fcaee8
Branch  : main
Author  : Steve Crouch <s.crouch@software.ac.uk>
Time    : 2025-04-01 09:44:37 +0000
Message : Merge pull request #424 from carpentries-incubator/optinal-exercises

Small wording fixes to optional exercises
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
Auto-generated via `{sandpaper}`
Source  : 2a9c7fb
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-04-01 09:45:29 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 8fcaee8
Branch  : main
Author  : Steve Crouch <s.crouch@software.ac.uk>
Time    : 2025-04-01 09:44:37 +0000
Message : Merge pull request #424 from carpentries-incubator/optinal-exercises

Small wording fixes to optional exercises
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants